Add retry count and retry time to login program#134
Merged
Conversation
kdj0c
reviewed
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #122 by adding retry login when restarting the login program in the sig_child function. MAX_RETRY_COUNT and MAX_RETRY_TIME are used with values of 5 tries and 10s respectively. These values are from systemd's defaults for restarting a service on failure. This logic updates the retry count if it has been less than 10s since the terminal session started and checks if more than 5 retry attempts have occurred in this time period and stops any further retry attempts.