Merged
Conversation
If you set multiple layout with localectl, and have an options to
toggle layout, you can't toggle the layout in kmscon.
for example, with this localectl settings:
System Locale: LANG=el_GR.UTF-8
VC Keymap: gr
X11 Layout: gr,us
X11 Model: pc105
X11 Variant: ,
X11 Options: grp:alt_space_toggle
The reason is that xkbcommon won't use the XKB_DEFAULT_OPTIONS
environment variable if options is an empty string.
So if all variables are empty, use NULL instead.
https://github.com/xkbcommon/libxkbcommon/blob/dd642359f8d43c09968e34ca7f1eb1121b2dfd70/src/context-priv.c#L176
Signed-off-by: Jocelyn Falempe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you set multiple layout with localectl, and have an options to toggle layout, you can't toggle the layout in kmscon.
for example, with this localectl settings:
System Locale: LANG=el_GR.UTF-8
VC Keymap: gr
X11 Layout: gr,us
X11 Model: pc105
X11 Variant: ,
X11 Options: grp:alt_space_toggle
The reason is that xkbcommon won't use the XKB_DEFAULT_OPTIONS environment variable if options is an empty string. So if all variables are empty, use NULL instead.
https://github.com/xkbcommon/libxkbcommon/blob/dd642359f8d43c09968e34ca7f1eb1121b2dfd70/src/context-priv.c#L176