Skip to content

Comments

Remove login session tracking#105

Merged
Aetf merged 1 commit intoAetf:developfrom
michael-oberpriller:Remove-login-session-tracking
May 16, 2025
Merged

Remove login session tracking#105
Aetf merged 1 commit intoAetf:developfrom
michael-oberpriller:Remove-login-session-tracking

Conversation

@michael-oberpriller
Copy link

After further testing with different window managers, I found that login session tracking only seems to work with wlroots based window managers. This reverts login session tracking and adds a check for input events that the session is in the foreground. This has the same effect of preventing input events when using kmscon-launch-gui from my other pull request. This fixes #104 and GH-103.

@CoelacanthusHex
Copy link

When a graphical session is launched from a kmscon terminal, it will update the session type from "tty" to "wayland"/"x11".

It's not correct. Normally the xdg session type was set by the Display Manager when creating a session via PAM and the compositor won't touch it. But too many previous standalone WM users don't like DM and try to launch compositor by themselves after login, so Sway and Systemd adopt a workaround which allows the compositor change session type via DBus after it was launched. Of course, this way is only used by Sway. So

I found that login session tracking only seems to work with wlroots based window managers.

@Vogtinator
Copy link

Normally the xdg session type was set by the Display Manager when creating a session via PAM and the compositor won't touch it.

As a DM maintainer, I can confirm that.

Copy link
Owner

@Aetf Aetf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Aetf Aetf merged commit f4d9b6b into Aetf:develop May 16, 2025
@michael-oberpriller michael-oberpriller deleted the Remove-login-session-tracking branch July 22, 2025 19:57
@michael-oberpriller michael-oberpriller restored the Remove-login-session-tracking branch July 22, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kmscon loops at 100% cpu

4 participants