Closed
Conversation
monitor_sd_init needs to get a pointer to struct uterm_sd_mon to be able to initialize it. Previously its contents were never initialized.
Author
|
Before this fix, there was 100% CPU use after logout because |
Author
|
This broke in 61236ed ("Clean up monitors") |
|
Thanks for fixing this, but I will be making a new PR that reverts the broken commits since they did not work as expected. |
Author
|
Ok! I'll leave this open until the other PR is merged. |
|
Are both needed? |
Author
No, either of them will fix that specific issue. |
Author
|
Superseded by #105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
monitor_sd_init needs to get a pointer to struct uterm_sd_mon to be able to initialize it. Previously its contents were never initialized.