Repository navigation
[ECP-10044] Compare authorized amounts in minor units to complete split payments - #3397
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the isFullAmountAuthorized method in AdyenOrderPayment.php to compare authorization amounts in minor units using the Adyen data helper, replacing direct float comparisons to avoid precision issues. It also adds comprehensive unit tests with a data provider to validate this behavior across different currencies and partial payment scenarios. There are no review comments to address, and I have no feedback to provide.
shubhamk67
approved these changes
Oct 28, 2026
|
shanikantsingh
approved these changes
Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
For some split (partial) payments, the last
AUTHORISATIONwebhook did not complete the order: it was neither finalised nor invoiced, and only a history comment was added. Whether it happened depended on the amounts (e.g. 10.00 + 20.00 worked, 10.10 + 20.20 did not).AdyenOrderPayment::isFullAmountAuthorized()compared the grand total withpayment_authorization_amountusing===on floats.AuthorisationWebhookHandleradds each partial amount to the stored value, which is loaded fromsales_orderas a decimal string, so the sum can pick up float noise:"25.0000" + 4.99is29.990000000000002, which is not identical to29.99. Both amounts are now compared in minor units withData::formatAmount(), using the base currency forbaseand the order currency fordisplaycharged currency, the same way asisFullAmountFinalized()and v10. Amounts are therefore matched at the currency precision instead of 4 decimals. Based on the investigation and patch in #3379.Tested scenarios
Fixes #3352