feat: revert to the default Coloring for all other watchers #613
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0a83764 in 8 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/util/color.ts:144
- Draft comment:
The change fromgetCategoryColorFromString(e.data.title)togetColorFromString(getTitleAttr(bucket, e))alters the logic for determining the color for events not covered by specific conditions. Ensure thatgetTitleAttrreturns a consistent and expected string for color mapping, as this could affect color consistency across the application. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_AhTYIcFCd3oK4zjL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Previously lastfm and the media watcher were greyed out. I forgot to take a screenshot before :( |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
=======================================
Coverage 25.98% 25.98%
=======================================
Files 27 27
Lines 1643 1643
Branches 292 279 -13
=======================================
Hits 427 427
- Misses 1157 1190 +33
+ Partials 59 26 -33 ☔ View full report in Codecov by Sentry. |
|
Very nice! Do you think it's good enough to make a release out of once merged? :) |
|
Yeah we should probably make it a release. |
2 participants
This reverts to the previous coloring pattern for all watchers except window, afk, web, editor and stopwatch.
Important
Reverts default coloring logic for non-specific event categories in
getCategoryColorFromEvent()incolor.ts.getCategoryColorFromEvent()incolor.ts.getColorFromString(getTitleAttr(bucket, e))for non-specific categories (not window, afk, web, editor, stopwatch).This description was created by
for 0a83764. It will automatically update as commits are pushed.