Skip to content

fix: fixes issue with migrating category settings to the server #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ErikBjare merged 1 commit into from
Jun 10, 2024
Merged

fix: fixes issue with migrating category settings to the server #583

ErikBjare merged 1 commit into from
Jun 10, 2024

Conversation

@ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Jun 5, 2024 •
edited
Loading

@ErikBjare ErikBjare changed the title fix: started investigating solution for https://github.com/ActivityWa… fix: fixes issue with migrating category settings to the server Jun 5, 2024
@codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 26.13%. Comparing base (021acc4) to head (07bcda8).
Report is 3 commits behind head on master.

Files Patch % Lines
src/stores/settings.ts 9.09% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   26.15%   26.13%   -0.02%     
==========================================
  Files          27       27              
  Lines        1629     1630       +1     
  Branches      285      273      -12     
==========================================
  Hits          426      426              
- Misses       1177     1178       +1     
  Partials       26       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare force-pushed the dev/fix-serverside-categories-migration branch from 1e58c5a to 07bcda8 Compare June 10, 2024 12:46
@ErikBjare ErikBjare mentioned this pull request Jun 10, 2024
Closed
2 tasks
@ErikBjare ErikBjare marked this pull request as ready for review June 10, 2024 12:47
BelKed
BelKed approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@BelKed BelKed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified, works as intended. The error doesn't show up in the UI and the data is displayed normally :)

@ErikBjare
Copy link
Member Author

ErikBjare commented Jun 10, 2024

@BelKed Did you check the codepath by reproducing the error? (possibly by removing the entry in the server-side settings)

@ErikBjare ErikBjare merged commit 54769b7 into master Jun 10, 2024
@ErikBjare ErikBjare deleted the dev/fix-serverside-categories-migration branch June 10, 2024 14:16
@BelKed
Copy link
Contributor

BelKed commented Jun 10, 2024

@BelKed Did you check the codepath by reproducing the error? (possibly by removing the entry in the server-side settings)

Yes, exactly:

  1. Removed the classes entry from the database.
  2. Added an empty classes entry to the localStorage (localStorage.setItem("classes", ""))
  3. The error doesn't appear anymore :)

@ErikBjare
Copy link
Member Author

ErikBjare commented Jun 10, 2024

Awesome, triggering a build for v0.13.1 now.

This was referenced Jun 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BelKed BelKed BelKed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: e.slice().map is not a function error after updating to version 0.13

3 participants

@ErikBjare @BelKed