fix: only save updated settings to server, store theme and landingpage in localStorage as well #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in localStorage as well
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to fbe6019 in 1 minute and 21 seconds
More details
- Looked at
181lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/components/UserSatisfactionPoll.vue:106
- Draft comment:
Removing the initialization ofdatain themountedhook assumes that the store always correctly initializesdata. Consider adding error handling or a fallback mechanism to ensuredatais correctly initialized to prevent potential runtime errors. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_UiKlvVh9keQhJ1aS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 9 days left in your free trial, upgrade for $20/seat/month or contact us.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
- Coverage 26.28% 26.15% -0.14%
==========================================
Files 27 27
Lines 1613 1629 +16
Branches 276 285 +9
==========================================
+ Hits 424 426 +2
- Misses 1132 1145 +13
- Partials 57 58 +1 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568
Summary:
This PR optimizes settings handling by removing unused code, refactoring state management, and ensuring crucial settings are stored locally for immediate access.
Key points:
UserSatisfactionPoll.vue.jsonEqinsettings.tsto optimize settings storage.settings.ts.Generated with ❤️ by ellipsis.dev