fix: hopefully actually fixes bug in category builder for 'constructor' word (and other prototype stuff) #565
Conversation
…r' word (and other prototype stuff)
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b5e9eb0 in 21 seconds
More details
- Looked at
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. src/views/settings/CategoryBuilder.vue:227:
- Assessed confidence :
0% - Comment:
The changes from using an object to aMapfor storing words are correctly implemented. This should prevent issues with words that match Object properties like 'constructor'. Good job on this fix. - Reasoning:
The PR changes the way words are stored and accessed from an object to a Map. This is a good change for handling properties that have names that could conflict with object properties (like 'constructor'). The changes are consistent and correctly implemented across the modified lines.
Workflow ID: wflow_0JibP7twdPhVnItF
You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
⌛ 12 days left in your free trial, upgrade for $20/seat/month or contact us.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
=======================================
Coverage 25.60% 25.60%
=======================================
Files 27 27
Lines 1613 1613
Branches 286 286
=======================================
Hits 413 413
- Misses 1141 1174 +33
+ Partials 59 26 -33 ☔ View full report in Codecov by Sentry. |
|
@john30 Haven't tested (again), but I think this should be correct now. |
There was a problem hiding this comment.
sorry but still not correct. as commented before, all occasions of this.words need to be checked and most probably adjusted as well.
just try the following in the browser console:
your patch would yield in behaviour such as m=new Map();m.set('example',1);console.log(Object.keys(m)) resulting in an empty array instead of an array with 'example' as the single element, because the Map can not be used like this.
instead, new Map().keys() would have to be used but it returns an iterator (and not an array as expected somewhere in the code) so that needs to be adjusted accordingly
just out of curiosity: why do you push and merge immediately before anyone had the chance to review it?
Follow up on #564
Summary:
Updated
CategoryBuilder.vueto useMapfor storing words, replacing object structure to handle prototype-related issues correctly.Key points:
MapinCategoryBuilder.vue.inkeyword withMapmethods (has,get,set) to avoid prototype pollution.Generated with ❤️ by ellipsis.dev