Skip to content

Conversation

@ErikBjare
Copy link
Member

Continuing on 9896601

There are more bad uses of localStorage in the code that should be cleaned up.

@codecov
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (845b12f) 25.55% compared to head (fd538bb) 25.58%.

Files Patch % Lines
src/route.js 0.00% 1 Missing and 1 partial ⚠️
src/util/color.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   25.55%   25.58%   +0.03%     
==========================================
  Files          27       27              
  Lines        1616     1618       +2     
  Branches      273      272       -1     
==========================================
+ Hits          413      414       +1     
- Misses       1177     1178       +1     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare merged commit 23df3fb into master Jan 8, 2024
@ErikBjare ErikBjare deleted the dev/fix-localStorage-uses branch January 8, 2024 11:32
ErikBjare added a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants