Filtering clients and hosts on timeline #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
requested changes
Nov 17, 2023
Member
ErikBjare
left a comment
ErikBjare
left a comment
There was a problem hiding this comment.
Neat, just some minor things
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #502 +/- ##
=======================================
Coverage 23.92% 23.92%
=======================================
Files 27 27
Lines 1605 1605
Branches 267 267
=======================================
Hits 384 384
Misses 1196 1196
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Good points, done. |
ErikBjare
approved these changes
Nov 19, 2023
Member
|
Merged 🎉 Thanks for your contribution! ❤️ |
Member
|
Made some improvements in 609a7cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option enable user to filter events from different devices or event types on timeline.