fix(sync): remove bug-causing workaround for spurious small db files (fixes #466) #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 952716a in 8 seconds
More details
- Looked at
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. aw-sync/src/sync_wrapper.rs:41
- Draft comment:
The removal of the filter for small database files should resolve the issue of not finding any database files, as it allows all files to be considered. The logic for selecting the largest database file remains intact, which is a good practice to ensure the most complete data is used. - Reason this comment was not posted:
Confidence changes required:0%
The PR removes a filter that excluded small database files. This change should resolve the issue of not finding any database files, as it allows all files to be considered. However, the logic for selecting the largest database file remains intact, which is a good practice to ensure the most complete data is used.
Workflow ID: wflow_pD3sSLdypSAOqMUk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @krzysid in #466 (comment)
Important
Removes size-based filtering of database files in
pull()insync_wrapper.rs, fixing a bug with spurious small files.pull()insync_wrapper.rs..dbfiles regardless of size.This description was created by
for 952716a. It will automatically update as commits are pushed.