Split client to async and blocking #396
Conversation
|
This watcher doesn't use |
|
One alternative would be "async generic" so to speak: https://docs.rs/maybe-async/0.2.6/maybe_async/ - it would exclude tokio from crate's dependencies ( |
|
Hmm, can't figure out why CI doesn't run |
Reqwest uses tokio blocking internally as well.
ErikBjare
force-pushed
the
async-client
branch
from
9e0f8b5 to
36c86ab
Compare
|
CI passed fine in #419, force-pushed the rebased commit here and merging :) |
2 participants
The problem is not only that the current functionality is less useful in async context. The client cannot be used in async context at all as is:
https://docs.rs/reqwest/latest/reqwest/blocking/
I've used tokio's runtime to block because reqwest uses tokio blocking internally as well.
https://github.com/seanmonstar/reqwest/blob/master/src/blocking/wait.rs
It also uses a current thread runtime, but with timeouts. However, the async client specified the timeout already, so it shouldn't matter much.