Skip to content

Conversation

@johan-bjareholt
Copy link
Member

No description provided.

@johan-bjareholt
Copy link
Member Author

@ErikBjare Unfortunately still does not build with rust stable because the "plex" dependency for aw-query still needs nightly :(

@johan-bjareholt johan-bjareholt force-pushed the dev/rocket-0.5 branch 4 times, most recently from cee16d2 to 7692dbd Compare November 14, 2021 21:47
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #255 (5ded15e) into master (b5c722f) will decrease coverage by 8.49%.
The diff coverage is 64.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   58.97%   50.47%   -8.50%     
==========================================
  Files          45       45              
  Lines        5216     6167     +951     
==========================================
+ Hits         3076     3113      +37     
- Misses       2140     3054     +914     
Impacted Files Coverage Δ
aw-server/src/main.rs 0.00% <0.00%> (ø)
aw-transform/src/split_url.rs 13.33% <0.00%> (+0.83%) ⬆️
aw-server/src/endpoints/mod.rs 69.38% <10.00%> (-2.66%) ⬇️
aw-server/src/endpoints/hostcheck.rs 61.53% <38.46%> (-3.47%) ⬇️
aw-server/src/config.rs 48.71% <92.30%> (+0.66%) ⬆️
aw-server/src/endpoints/util.rs 81.35% <95.00%> (+5.74%) ⬆️
aw-server/src/endpoints/bucket.rs 81.87% <100.00%> (+1.62%) ⬆️
aw-server/src/endpoints/export.rs 88.23% <100.00%> (-4.08%) ⬇️
aw-server/src/endpoints/import.rs 100.00% <100.00%> (+10.90%) ⬆️
aw-server/src/endpoints/query.rs 100.00% <100.00%> (+4.76%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c722f...5ded15e. Read the comment docs.

@ErikBjare
Copy link
Member

Unfortunately still does not build with rust stable because the "plex" dependency for aw-query still needs nightly :(

Ah, I followed some issues and doesn't look like it's happening anytime soon.

Oh well, still good work on rocket 0.5.0!

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, nice changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants