fix: added potential workaround for failing NSBundle bundleIdentifier check in desktop-notifier

ErikBjare · ErikBjare · commit c640ee33ee26 · 2023-11-27T20:13:18.000+01:00
diff --git a/aw_notify/main.py b/aw_notify/main.py
@@ -3,6 +3,7 @@
 and send notifications to the user on predefined conditions.
 """
 import logging
+import platform
 import threading
 from collections import defaultdict
 from datetime import datetime, timedelta, timezone
@@ -252,6 +253,16 @@ def main(ctx, verbose: bool, testing: bool):
     logging.getLogger("urllib3").setLevel(logging.WARNING)
     logger.info("Starting...")
 
+    # set NSBundle on macOS, needed for desktop-notifier
+    if platform.system() == "Darwin":
+        from rubicon.objc import ObjCClass
+
+        # needs to be the same as the one in the PyInstaller config (later Info.plist)
+        # could also be done by just monkey-patching the helper function is_signed_bundle in desktop-notifier
+        # see: https://github.com/samschott/desktop-notifier/issues/115
+        NSBundle = ObjCClass("NSBundle")
+        NSBundle.mainBundle.bundleIdentifier = "net.activitywatch.ActivityWatch"
+
     if ctx.invoked_subcommand is None:
         ctx.invoke(start)
 
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -16,6 +16,7 @@ aw-notify = "aw_notify.main:main"
 python = "^3.9,<3.12"
 aw-client = "^0.5.13"
 desktop-notifier = "^3.4.2"
+rubicon-objc = { version = "^0.4.0", platform = "darwin" }
 
 [tool.poetry.group.dev.dependencies]
 black = "*"
