Benchmarking with ASV #456
Conversation
this can prevent upcoming benchmarking tool from pounding relentlessly on activitysim_resources repo, by caching the large file downloads
…nce1 # Conflicts: # activitysim/examples/example_manifest.yaml
|
This work is ready for review, and passes tests in Travis. The benchmarking results website is online at https://activitysim.github.io/asim-benchmarks/ |
There was a problem hiding this comment.
Pull request in general looks really good. Code needs to be more consistent when it comes to chunking and multiprocessing (there are multiple spots that seem to contradict each other as to whether multiprocessing & chunking are enabled or not). More documentation would help developers and users understand the functionality and how to use it appropriately. I did get an error when trying to publish to GitHub pages that should be addressed.
Does a TravisCI test need to be created to test the benchmarking functionality?
temporary fix cf ActivitySim#533
|
@dhensle, I believe we have addressed all of the items you identified in your review, can you confirm? Thanks |
dhensle
left a comment
dhensle
left a comment
There was a problem hiding this comment.
All of my previous comments have been addressed. Looks good to me!
fix for dependency changes that result in small parameter estimation variance
4 participants
work on #439