-
Notifications
You must be signed in to change notification settings - Fork 118
Closed
Description
Should the coefficients line 96 be added to the local dictionary before the expressions are evaluated for the preprocessor_settings? In the ARC implementation, tour_mode_choice_annotate_choosers_preprocessor.csv, references coefficients defined in the tour_mode_choice_coeffs and tour_mode_choice_coeffs_templates. They would only be available if the coefficients were added to the local_dict before the expressions are evaluated in line 88.
activitysim/activitysim/abm/models/util/vectorize_tour_scheduling.py
Lines 84 to 98 in 05a25f6
| if preprocessor_settings: | |
| simulate.set_skim_wrapper_targets(choosers, skims) | |
| expressions.assign_columns( | |
| df=choosers, | |
| model_settings=preprocessor_settings, | |
| locals_dict=locals_dict, | |
| trace_label=trace_label) | |
| # - compute logsums | |
| coefficients = simulate.get_segment_coefficients(logsum_settings, tour_purpose) | |
| logsum_spec = simulate.read_model_spec(file_name=logsum_settings['SPEC']) | |
| logsum_spec = simulate.eval_coefficients(logsum_spec, coefficients, estimator=None) |
Metadata
Metadata
Assignees
Labels
No labels