Allow installing without setuptools #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setuptools v34 requires appdirs, which creates an obvious bootstrap problem if appdirs uses setuptools in its setup.py. Therefore, allow installing with distutils if setuptools is not available.
|
I was literally about to contribute the exact same patch. Thanks for doing this! |
adamjstewart
approved these changes
Feb 21, 2017
adamjstewart
added a commit
to adamjstewart/spack
that referenced
this pull request
Feb 21, 2017
tgamblin
pushed a commit
to spack/spack
that referenced
this pull request
Feb 21, 2017
…ored (#3198) * Fix setuptools bootstrapping now that dependencies are no longer vendored * Reorder patch and comments * Use exact same patch as ActiveState/appdirs#84 * Use exact same patch as https://sourceforge.net/p/pyparsing/patches/10/
This was referenced Feb 21, 2017
|
Thanks for sending this along. Cheers. |
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
…ored (spack#3198) * Fix setuptools bootstrapping now that dependencies are no longer vendored * Reorder patch and comments * Use exact same patch as ActiveState/appdirs#84 * Use exact same patch as https://sourceforge.net/p/pyparsing/patches/10/
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
…ored (spack#3198) * Fix setuptools bootstrapping now that dependencies are no longer vendored * Reorder patch and comments * Use exact same patch as ActiveState/appdirs#84 * Use exact same patch as https://sourceforge.net/p/pyparsing/patches/10/
amklinv
pushed a commit
to spack/spack
that referenced
this pull request
Jul 17, 2017
…ored (#3198) * Fix setuptools bootstrapping now that dependencies are no longer vendored * Reorder patch and comments * Use exact same patch as ActiveState/appdirs#84 * Use exact same patch as https://sourceforge.net/p/pyparsing/patches/10/
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Jul 26, 2017
…ored (spack#3198) * Fix setuptools bootstrapping now that dependencies are no longer vendored * Reorder patch and comments * Use exact same patch as ActiveState/appdirs#84 * Use exact same patch as https://sourceforge.net/p/pyparsing/patches/10/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools v34 requires appdirs, which creates an obvious bootstrap problem if appdirs uses setuptools in its setup.py. Therefore, allow installing with distutils if setuptools is not available.