-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tags #103
Support tags #103
Conversation
+1 |
Hey @DorZuberi would you mind giving this PR a look and suggest any changes? I am specifically wondering about your request for a filter as I am not super familiar with those beyond using core hooks and wondering if my proposed implementation would do the job. PHP and WordPress aren't core competencies of ours at ActiveCampaign Postmark so would appreciate any feedback on these changes. Thanks! |
Hi @pgraham3, |
Co-authored-by: Dor Zuberi <[email protected]>
@DorZuberi This has been released as version 1.18.0. Thanks for the help! Added you as a contributor in the plugin marketplace listing 🫡. |
Wow! I'm actually wanted to fork the repo and send you a PR with additional changes and aligning the plugin to WordPress's code conventions. |
That would be awesome! There are definitely improvements to be made to this plugin but I don't always have the time/experience to implement them, unfortunately. I work with Ruby/Rails/JavaScript day to day so some of the WordPress conventions and general PHP dev process like adding tests are not strong suits of mine. @bhubbard also has some useful PRs to setup CI and automated tests, deploy to SVN from a Github action, and more for us here that could use an experienced reviewer. If you ever feel like contributing more that would be super helpful too. Thanks again! |
Will do! I'm a long time user of Postmark, truly an amazing product. Keep up the good work! ❤️ |
Extracted from #67