Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags #103

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Support tags #103

merged 7 commits into from
Mar 17, 2023

Conversation

pgraham3
Copy link
Contributor

@pgraham3 pgraham3 commented Mar 15, 2023

Extracted from #67

@pgraham3 pgraham3 self-assigned this Mar 15, 2023
@DorZuberi
Copy link
Contributor

+1

@pgraham3
Copy link
Contributor Author

Hey @DorZuberi would you mind giving this PR a look and suggest any changes?

I am specifically wondering about your request for a filter as I am not super familiar with those beyond using core hooks and wondering if my proposed implementation would do the job. PHP and WordPress aren't core competencies of ours at ActiveCampaign Postmark so would appreciate any feedback on these changes.

Thanks!

@DorZuberi
Copy link
Contributor

Hi @pgraham3,
Looks great!

@pgraham3 pgraham3 merged commit b2724f4 into master Mar 17, 2023
@pgraham3 pgraham3 deleted the support-tags branch March 17, 2023 14:03
@pgraham3
Copy link
Contributor Author

@DorZuberi This has been released as version 1.18.0. Thanks for the help! Added you as a contributor in the plugin marketplace listing 🫡.

Screenshot 2023-03-17 at 10 27 32 AM

@DorZuberi
Copy link
Contributor

Wow!
Thanks!

I'm actually wanted to fork the repo and send you a PR with additional changes and aligning the plugin to WordPress's code conventions.

@pgraham3
Copy link
Contributor Author

That would be awesome! There are definitely improvements to be made to this plugin but I don't always have the time/experience to implement them, unfortunately. I work with Ruby/Rails/JavaScript day to day so some of the WordPress conventions and general PHP dev process like adding tests are not strong suits of mine.

@bhubbard also has some useful PRs to setup CI and automated tests, deploy to SVN from a Github action, and more for us here that could use an experienced reviewer. If you ever feel like contributing more that would be super helpful too.

Thanks again!

@DorZuberi
Copy link
Contributor

Will do!
Thanks!

I'm a long time user of Postmark, truly an amazing product.
The company which I work in also uses Postmark for a few years.

Keep up the good work! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants