Remove the default ssl version but leave it configurable

Nick Hammond · Nick Hammond · commit 529e9dba6d02 · 2020-12-01T09:36:28.000-07:00
diff --git a/lib/postmark/http_client.rb b/lib/postmark/http_client.rb
@@ -18,8 +18,7 @@ class HttpClient
       :secure => true,
       :path_prefix => '/',
       :http_read_timeout => 15,
-      :http_open_timeout => 5,
-      :http_ssl_version => :TLSv1
+      :http_open_timeout => 5
     }
 
     def initialize(api_token, options = {})
@@ -107,7 +106,7 @@ def build_http
       http.read_timeout = self.http_read_timeout
       http.open_timeout = self.http_open_timeout
       http.use_ssl = !!self.secure
-      http.ssl_version = self.http_ssl_version if http.respond_to?(:ssl_version=)
+      http.ssl_version = self.http_ssl_version if self.http_ssl_version && http.respond_to?(:ssl_version=)
       http
     end
   end
diff --git a/spec/unit/postmark/http_client_spec.rb b/spec/unit/postmark/http_client_spec.rb
@@ -42,9 +42,9 @@ def response_body(status, message = "")
     its(:http_read_timeout) { is_expected.to eq 15 }
     its(:http_open_timeout) { is_expected.to eq 5 }
 
-    it 'use default TLS encryption', :skip_ruby_version => ['1.8.7'] do
+    it 'does not provide a default which utilizes the Net::HTTP default', :skip_ruby_version => ['1.8.7'] do
       http_client = subject.http
-      expect(http_client.ssl_version).to eq :TLSv1
+      expect(http_client.ssl_version).to eq nil
     end
   end
 
@@ -140,7 +140,7 @@ def response_body(status, message = "")
                                               :status => [ "485", "Custom HTTP response status" ])
       expect { subject.post(target_path) }.to raise_error Postmark::UnknownError
     end
-    
+
   end
 
   describe "#get" do
@@ -180,7 +180,7 @@ def response_body(status, message = "")
                                              :status => [ "485", "Custom HTTP response status" ])
       expect { subject.get(target_path) }.to raise_error Postmark::UnknownError
     end
-    
+
   end
 
   describe "#put" do
@@ -223,4 +223,4 @@ def response_body(status, message = "")
       expect { subject.put(target_path) }.to raise_error Postmark::UnknownError
     end
   end
-end
+end
