Skip to content
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

Comments

Catch exception in Solution generation#6

Merged
sadreck merged 1 commit intoAccenture:mainfrom
kost:catch-exception-solution
Oct 9, 2023
Merged

Catch exception in Solution generation#6
sadreck merged 1 commit intoAccenture:mainfrom
kost:catch-exception-solution

Conversation

@kost
Copy link
Contributor

@kost kost commented Oct 6, 2023

Exception is not handled when file is not found or there is error in creating file. It stops creating all solutions after this unhandled exception with following error:

[07:08:37] Processing logfile64.dll[07:08:37] Could not find a part of the path 'C:\spartacus\logfile64.dll-file-not-found'.

Fix catches exception, so only solution which have error is not built. Building of other solution continues.

@sadreck sadreck merged commit f7ba109 into Accenture:main Oct 9, 2023
@sadreck
Copy link
Contributor

sadreck commented Oct 9, 2023

Thanks, your fix is now in v2.2.0

@kost
Copy link
Contributor Author

kost commented Oct 9, 2023

Thanks. Great. You're fast. Can I ask you to add label "hacktoberfest-accepted" label to this pull request?
For more info, check out: https://hacktoberfest.com/participation/#pr-mr-details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants