Upgrade gRPC and protobuf dependencies.#1185
Merged
bcipriano merged 5 commits intoAcademySoftwareFoundation:masterfrom Sep 29, 2022
Merged
Upgrade gRPC and protobuf dependencies.#1185bcipriano merged 5 commits intoAcademySoftwareFoundation:masterfrom
bcipriano merged 5 commits intoAcademySoftwareFoundation:masterfrom
Conversation
bcipriano
requested review from
DiegoTavares,
IdrisMiles,
gregdenton,
jrray,
larsbijl,
smith1511 and
splhack
as code owners
Collaborator
Author
|
Test failure is due to a problem with CueGUI unit tests and is unrelated to this change. We'll have to resolve it, but it's out of scope here. |
Collaborator
Author
|
@DiegoTavares Could I get a review here? Or maybe you want to try it out in one of your environments first? |
bcipriano
changed the title
Collaborator
Author
|
I added an upgrade of the Python dependency too as this will have the same problem. Best to keep them consistent anyway. |
This was referenced Sep 16, 2022
DiegoTavares
approved these changes
Sep 28, 2022
Collaborator
DiegoTavares
left a comment
DiegoTavares
left a comment
There was a problem hiding this comment.
Tested in our environment and all new libraries are available and the build worked just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #1204.
The older versions of these dependencies don't have builds published for the
osx-aarch_64architecture, which means I'm unable to build Cuebot on my M1 macbook.Anyway, these dependencies are a bit old, so good to update regardless as long as it doesn't cause issues elsewhere.