Repository navigation
Commit 0d56fde
authored
Replace pull_request_target workflows with pull_request + workflow_run (flutter#195536)
This resolves flutter#193185.
GitHub is restricting `pull_request_target`, which runs with secrets and
a write token on events from forks. Each affected workflow is split in
two:
* An unprivileged `pull_request` workflow with a read-only token and no
secrets. Cheap gates (label name, base branch, bot author) are job-level
`if:`s so non-matching events never allocate a runner. When it applies,
it uploads a small artifact with context about the triggering event (PR
number, and the cp channel).
* A privileged `workflow_run` workflow that runs from the default branch
with access to secrets. It downloads the artifact and does the actual
work: commenting, labeling, reverting, cherry-picking, deleting
branches.
A PR can modify the `pull_request` workflow, so the artifact is
untrusted. The privileged side ties the PR number to the triggering
run's head SHA and repo. It then reads all other state from the GitHub
API, including re-checking any gate whose failure would have made the
trigger skip. Checks that end in a comment either way are done only on
the privileged side.
| Unprivileged (pull_request) | Privileged (workflow_run) |
|---------------------------------|---------------------------|
| revert-trigger.yml | revert.yml |
| cp-trigger.yml | easy-cp.yml |
| labeler-trigger.yml | labeler.yml |
| delete-bot-branches-trigger.yml | delete-bot-branches.yml |
| freeze.yml | freeze-comment.yml |
| no-main-prs.yaml | no-main-prs-comment.yaml |
freeze.yml and no-main-prs.yaml keep their names because they still
provide the PR check. no-main-prs.yaml now gates on `base_ref == 'main'`
at the job level, so it no longer uses a runner on every PR.1 parent 7fb7236 commit 0d56fde
17 files changed
Lines changed: 1073 additions & 187 deletions
File tree
- .agents/skills/flutter-cherry-pick/scripts
- .github/workflows
- docs
- contributing
- infra
- releases
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
91 | 141 | | |
92 | 142 | | |
93 | 143 | | |
| |||
172 | 222 | | |
173 | 223 | | |
174 | 224 | | |
175 | | - | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
176 | 228 | | |
177 | 229 | | |
178 | 230 | | |
| |||
379 | 431 | | |
380 | 432 | | |
381 | 433 | | |
382 | | - | |
| 434 | + | |
383 | 435 | | |
384 | 436 | | |
385 | 437 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
5 | 13 | | |
6 | 14 | | |
7 | 15 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
13 | 22 | | |
14 | 23 | | |
15 | | - | |
| 24 | + | |
16 | 25 | | |
17 | 26 | | |
18 | 27 | | |
19 | 28 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
25 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
26 | 90 | | |
27 | 91 | | |
28 | 92 | | |
29 | | - | |
30 | | - | |
31 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
32 | 96 | | |
33 | 97 | | |
34 | 98 | | |
0 commit comments