Skip to content

Commit 56c717c

Browse files
authored
[ios]do not nuke user input path when running uiscene integration test (flutter#186436)
As discussed in flutter#186412 (comment). > It's safer to only delete the folders/files that flutter itself controls. The script can create the project folder under the path (e.g. generated_project). Then when deleting, we only delete generated_project folder (the "Expected" behavior in the description) Note: 1. The documentation itself is fine tho, so I will keep it untouched. 2. It looks like we don't have infra setup to write unit tests for test scripts, so I will leave it as out-of-scope of this PR. 3. But in the future we should be heading towards dumb logic in test scripts, and leverage Xcode build targets & file memberships instead. 4. I think this is a broader security issue than just this particular script - I wish our flutter/dart tooling could have asked for permission for dangerous operations like this. I filed flutter#186419 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* Fixes flutter#186412 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 8747e2f commit 56c717c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎dev/devicelab/bin/tasks/module_uiscene_test_ios.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Future<void> main(List<String> args) async {
4040
var destinationOverride = false;
4141
if (destination != null) {
4242
destinationOverride = true;
43-
destinationDir = Directory(destination);
43+
destinationDir = Directory(path.join(destination, 'flutter_uiscene_test_generated_project'));
4444
if (destinationDir.existsSync()) {
4545
destinationDir.deleteSync(recursive: true);
4646
}

0 commit comments

Comments
 (0)