Repository navigation
Commit 1e847f2
[flutter_tools] Include flutter.js.map in web builds (flutter#192257)
The prebuilt Flutter web loader ends with a reference to
`flutter.js.map`. The matching source map is already part of the Flutter
web SDK, but `WebBuiltInAssets` only copies `flutter.js` and CanvasKit
into `build/web`. As a result, browser developer tools request a file
that is missing from every web build, and tools such as error reporters
cannot resolve stack frames from the loader.
This change declares `flutter.js.map` as a built-in web output and
copies it alongside `flutter.js`.
The copy is intentionally independent of `--[no-]source-maps`. That
option controls source maps produced while compiling the application,
while `flutter.js` is a prebuilt SDK artifact that always references its
own prebuilt map.
Fixes flutter#145111.
## Validation
- `./bin/dart --enable-asserts dev/bots/analyze.dart`
- `../../bin/dart test
test/general.shard/build_system/targets/web_test.dart` (626 tests)
- `bin/flutter-dev build web`
- incremental rebuild after removing `build/web/flutter.js.map`
- `bin/flutter-dev build web --source-maps`
- `bin/flutter-dev build web --wasm`
- verified the emitted map is byte-for-byte identical to the Flutter web
SDK artifact
No changes to `flutter/tests` are required.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Mouad Debbar <[email protected]>1 parent 9c93149 commit 1e847f2
2 files changed
Lines changed: 31 additions & 8 deletions
File tree
- packages/flutter_tools
- lib/src/build_system/targets
- test/general.shard/build_system/targets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1490 | 1490 | | |
1491 | 1491 | | |
1492 | 1492 | | |
| 1493 | + | |
1493 | 1494 | | |
1494 | 1495 | | |
1495 | 1496 | | |
| |||
1506 | 1507 | | |
1507 | 1508 | | |
1508 | 1509 | | |
1509 | | - | |
1510 | | - | |
1511 | | - | |
1512 | | - | |
1513 | | - | |
1514 | | - | |
1515 | | - | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
1516 | 1513 | | |
1517 | | - | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
1518 | 1519 | | |
1519 | 1520 | | |
1520 | 1521 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
87 | 90 | | |
88 | 91 | | |
89 | 92 | | |
| |||
1730 | 1733 | | |
1731 | 1734 | | |
1732 | 1735 | | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
1733 | 1755 | | |
1734 | 1756 | | |
1735 | 1757 | | |
| |||
0 commit comments