Repository navigation
ci: fix the first CI run - #1
Closed
AbdurahmanAlmehdi wants to merge 4 commits into
Closed
AbdurahmanAlmehdi wants to merge 4 commits into
AbdurahmanAlmehdi wants to merge 4 commits into
Conversation
Bundle ID, LaunchAgent labels, Keychain service prefix, method channel and release URLs now live under ly.abdurahman.xpath (ADR 0005).
Run tests without the VGV optimizer so file-level tags hold, find openapi.yaml without Isolate, and resolve cspell ignore paths from the repo root.
Owner
Author
|
Squash-merged locally into main as f71bcf2. |
AbdurahmanAlmehdi
added a commit
that referenced
this pull request
Oct 17, 2026
## Problem XPath 1.0.0 (54) crashed on macOS 26.7.1 while it was in the background: `EXC_BAD_ACCESS` at `0x0` on `io.flutter.raster`, in `impeller::Canvas::SetupRenderPass()` (canvas.cc:1615), called from `EmbedderExternalViewEmbedder::SubmitFlutterView`. ## Root cause: a Flutter engine bug This is [flutter/flutter#185394](flutter/flutter#185394), "[Impeller] Crash on macOS when app is foregrounded" (open, P2, team-macos). The macOS back-buffer cache (`FlutterBackBufferCache`) can hand back a surface of the wrong size when the window's frame size changes and then changes back (A → B → A). Examples are a display hot-plug or reconfiguration, a Space or full-screen change, a window drag, or bringing the app to the front. Impeller wraps the mismatched `MTLTexture`, the texture invalidates itself, and the render target silently drops it. `SetupRenderPass` then dereferences the null texture. - Fix: [flutter/flutter#192522](flutter/flutter#192522) is still **open** (not merged). It is not in 3.47.7 (the latest stable, per its CHANGELOG) or in the 3.50 beta. - Also reported: #193095 (same stack) and #192829 (Cmd-Tab on macOS 27, closed as a duplicate). **Reproduced on our pinned SDK (3.47.6, release build).** This used a minimal scratch app, not XPath. A Swift timer shrinks the window by 1 pt and restores it every 2.5 s, which is the driver from #192522. The Flutter side redraws a text once a second, the way `XpClock` does: | Renderer | UI | Result | |---|---|---| | Impeller (default) | 1 s ticking text | **SIGSEGV after 5 s, at flip #1.** The stack matches the field crash frame for frame (canvas.cc:1615 / 372, dl_dispatcher.cc:1318, embedder_external_view_embedder.cc:376 / 598). | | Impeller | still UI | survived 60 s (17 flips) | | Skia (`FLTEnableImpeller=false`) | 1 s ticking text | **survived 90 s (36 flips)**, with no validation errors and the log line `Using the Skia rendering backend (Metal).` | ## Changes 1. **`macos/Runner/Info.plist`: `FLTEnableImpeller = false`** (with a comment linking the issues). I checked the 3.47.6 engine source to confirm macOS still reads this key: `FlutterDartProject.enableImpeller` reads it, and `FlutterEngine runWithEntrypoint` then skips `--enable-impeller=true` and uses Skia (Metal). XPath uses no Impeller-only features (no fragment shaders, Flutter GPU or backdrop filters). Goldens and widget tests are unaffected because `flutter test` does not read `Info.plist`. 2. **`XpClock` follows the app lifecycle** using an `AppLifecycleListener`. It ticks only while the app is `resumed`. When the app is `inactive` (visible but not in front), `hidden` (occluded or minimised) or `paused`, the timer stops. On resume, every live duration is rebuilt at once against the current time. The new `XpClock.isLive(context)` tells widgets whether the app is in front. 3. **`XpSpinner`** stands still while `!XpClock.isLive`, as it already does under Reduce Motion. Change 1 is the fix. Changes 2 and 3 mean XPath draws no frames of its own while it is not in front (it used to draw one a second for the clock, and 60 fps per spinner). That lowers the crash exposure and saves CPU and battery. On its own it does **not** fix the engine bug: a display change still causes a frame, and upstream reports idle apps crashing too. ## Tests `apps/xp_desktop/test/widgets/xp_clock_test.dart` drives the real `flutter/lifecycle` platform channel, the same messages the macOS embedder sends: - `XpClock ticks every second while the app is in front` - `XpClock stops while inactive|hidden|paused and catches up on resume` - `XpClock a still clock stays still in front and away` - `XpClock starts still when the app is already away` - `XpClock without a clock above, the system time is live` - `XpClock spinners stand still while the app is away` ## Trade-offs and follow-ups - Skia is Flutter's legacy renderer on macOS. The Flutter docs warn that the Impeller opt-out will be removed in a future release, and with Skia there is no wide-gamut colour. Once a Flutter stable ships #192522, remove the key (the Info.plist comment says so). - While XPath is visible but not in front, elapsed times stay frozen until it comes back to the front, and then catch up at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs tests without the VGV test optimizer (file-level
@Tagssuch asmacoswere lost when tests were bundled), loadsopenapi.yamlthroughpackage_config.jsonbecauseflutter testcannot resolve package URIs, and resolves cspellignorePathsfrom the repo root.