Repository navigation
test: the interleaved-args probe runs unconditionally instead of skipping - #447
Merged
Merged
Conversation
…ping pytest-dev/pytest#14968 (the 9.1.x backport of the pytest-dev/pytest#14971 fix) is still unreleased: PyPI's newest pytest is 9.1.1, so there is no version to adopt and the upstream-behavior probe version-gated on (9, 2, 0) skipped on every board, verifying nothing. The upstream bug is specific to fixtures defined in a nested conftest.py (re-collection of the revisited directory builds a second Directory node and fixture registration matches by node identity). Fixtures that do not ride a re-collected Directory node - the root conftest.py and each test module's own fixtures - resolve under the same interleaving; verified against 9.1.1 and 8.4.2 scratch projects, with the nested-conftest negative control erroring on 9.1.1 exactly as upstream reports. Replace the skip with a probe of that scenario: root conftest fixture plus per-module fixtures, asserted under both argument orderings. The nested conftest shape stays covered at the repo level by the two guards (web_admin fixtures registered from tests/conftest.py). A nested-conftest variant of the probe can be added once the pin moves past the release that ships the backport.
ZEAZX26
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-cause fix for the every-board skip at test_web_admin_fixture_resolution.py:111 (pytest 9.1.1 predates the #14968 backport of #14971: nested conftest fixtures drop under interleaved file args). Empirically pinned the mechanism on scratch projects, then restructured the probe: root-conftest fixture + per-module inline fixtures dodge the Directory re-collection bug entirely, so the SAME order-independence semantics are verified on every run - no skip, no version gate. The nested-conftest variant can return when the locked pytest ships the backport (recorded in a comment). Probe green x3 both orderings plus randomized; guards untouched; ruff/format/pyright clean.