Skip to content

upgrade to mypy action v0.15.0#257

Merged
jtherrmann merged 9 commits intodevelopfrom
update-mypy-options
Jan 22, 2025
Merged

upgrade to mypy action v0.15.0#257
jtherrmann merged 9 commits intodevelopfrom
update-mypy-options

Conversation

@jtherrmann
Copy link
Copy Markdown
Contributor

@jtherrmann jtherrmann commented Jan 18, 2025

We were enabling explicit_package_bases to solve the duplicate conftest.py error, but then when we remove the --ignore-missing-imports option by upgrading the mypy action, it turns out that mypy can't find any of the asf_tools.* imports. When we remove explicit_package_bases and instead exclude conftest.py files, we're left with 27 errors to address. This seems reasonable, though I wonder if there's a better way that doesn't exclude the conftest.py files.

Edit: The solution is to add a tests/__init__.py file, which is also recommended by pytest.


call-mypy-workflow:
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.15.0

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions Job or Workflow does not set permissions
@jtherrmann jtherrmann marked this pull request as ready for review January 18, 2025 19:45
@jtherrmann jtherrmann requested a review from a team January 18, 2025 19:45
@jtherrmann jtherrmann merged commit 39baaff into develop Jan 22, 2025
@jtherrmann jtherrmann deleted the update-mypy-options branch January 22, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants