MAC projector with Robin BCs needs initialization every time. The (#125)

cgilet · web-flow · commit 111a42c002dc · 2024-03-04T13:06:03.000-08:00
underlying solver, (EB)MLABecLaplacian, is not safe for reuse with Robin
BCs.
diff --git a/Projections/hydro_MacProjector.cpp b/Projections/hydro_MacProjector.cpp
@@ -212,10 +212,12 @@ MacProjector::setLevelBC (int amrlev, const MultiFab* levelbcdata, const MultiFa
                                      "setDomainBC must be called before setLevelBC");
     m_linop->setLevelBC(amrlev, levelbcdata, robin_a, robin_b, robin_f);
     m_needs_level_bcs[amrlev] = false;
+    if (robin_a) {
+        m_needs_init = true; // Solver is not safe for reuse with Robin BC
+    }
 }
 
 
-
 void
 MacProjector::project (Real reltol, Real atol)
 {

Original file line number	Diff line number	Diff line change
`@@ -212,10 +212,12 @@ MacProjector::setLevelBC (int amrlev, const MultiFab* levelbcdata, const MultiFa`
`212`	`212`	`"setDomainBC must be called before setLevelBC");`
`213`	`213`	`m_linop->setLevelBC(amrlev, levelbcdata, robin_a, robin_b, robin_f);`
`214`	`214`	`m_needs_level_bcs[amrlev] = false;`
	`215`	`+ if (robin_a) {`
	`216`	`+ m_needs_init = true; // Solver is not safe for reuse with Robin BC`
	`217`	`+ }`
`215`	`218`	`}`
`216`	`219`
`217`	`220`
`218`		`-`
`219`	`221`	`void`
`220`	`222`	`MacProjector::project (Real reltol, Real atol)`
`221`	`223`	`{`