Merged
Conversation
routines to compute other types of reactors (only UV was available but this is not going to work with PeleLM)
- Add a compile flag to choose DVODE integration, otherwise CVODE is chosen (USE_DVODE). Modify Makefiles in Reactions folder accordingly. - Add an extra parameter to the reactor_init to choose which type of reactor to use (choose 1 for retro compatibility). Modify Null and Null_air folder for compatibility (but this is a bit unclear in my head) - Put all actual_reactor routines(Fuego, Null, Null_air) in F90 - Add the cpp routines for cvode in Reactions/Fuego folder (not yet tested)
in Reaction folder. in particular, add the now mandatory argument to "actual_reactor_init" routine to choose the type of reactor for the chemistry integration
initialization too
difference between initial and reacted states !! We may go back if for some reason this was a relevant setup, which is why I commit this separately from everything else
CAREFULL: removal of useless rwrk and iwrk everywhere, so it is necessary to remove these arguments in all calls to fuego functions everywhere in dependent codes (like PeleC) !
It is consistent with the DVODE pre existing Tutorial and should be directly used to compare results.
chemistry Fuego routines are called
initial T in the tutorial.
chemistry integrators (fuego, Null, Null_air). For consistency, all react functions in F90 files are now compatible with react functions of CVODE, and can be called from C. Also, update ReactEval Tutorial to call dvode via react() with correct arguments
[REGTESTS] Add a test to check the chemistry in the PelePhysics-tests.ini
…pe before Finalize call
…at new Jac used for each cell. This makes runs much slower, but makes the integrator independent of the order of cell visits - allows OMP and non-OMP runs to agree for reg testing.
always_new_J = true for regtests to pass)
Cvode c merge
drummerdoc
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add kin. energy derive function. * Add kin.energy derive and ParmParse temporals input. * Start setting-up run-time diagnostics. * Update MLNorm0 to not account for fine-covered cells. * Setup mass balance in runtime diagnostics. * Add temporal keys to FlameSheet regtests * Git ignore * Add gnuplot script for mass balance.
drummerdoc
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Move the CoveredMask reset flag out of the if statement. * Add user-defined chemistry tolerances. * Add a Triple flame in Exec/Cases/TripleFlame * While making new level from coarse, get 1 ghost cell right so that AmrNewTime data have one ghost cell properly set. * Add a simple 2D CH4/Air premixed bunsen case. Tested up to 5 levels. * Add a 3Dversion of the premixed bunsen flame. * Need to reset the covered cell mask after restart in case regrid is not called right after. * Add option to restart an efield simulation from a non-efield one. * When restarting from non-efield chk, initialize electro-neutral nE field. * Fix PlotFile to plot I_R(nE) with efield and write/read in phiV/nE in chk. * Machinery to restart from non-efield chk. * Update Precond operator to implement the second approximation of Stilda. * Make use of the absolute tolerance in MLGMRES. * Add fillpatch functions for the non-linear state components. * Enable Schur complement approximation 2. * Define and ParmParse m_ef_schur_approx. * Floor nE along with species if required. * Fix typos in PeleLMBC.cpp * Update PeleLMeX header for new fillpatch functions. * Replace mechanism.h by mechanism.H * Setup gravity. * Use gravity in velocity forces. * Replace .copy by .ParallelCopy. * Add a lifting hot bubble case in RegTests. * Default the pprocConvOrder.py to CoVo inputs. * Enable CoVo in all directions. * Default input.2d_CoVo to diagonal direction. * Update pprocConvOrder.py with version checking the convergence order. * Init convergence testing CI. * Fix convergence CI (#6) * Fix deps in convergence CI. * Update pprocConvOrder.py. * Fix Pele Physics (#7) * Update make system to catch up with PP. * Update sources for latest PP. * Fix parsing of constant transport parameters. * Switch AMReX-Hydro (#8) * Add AMReX-Hydro to deps and GMake. * Remove LMX Godunov folder from listed sources. * Fix AMReX-Hydro makefile again and need MOL. * Swtich to HydroUtils to predict velocity and use create_umac_grown_constrained. * Remove stranded Godunov include. * Add m_advection_type. Only Godunov in LMeX. * Switch to HydroUtils::ComputeFluxesOnBoxFromState for advection fluxes. * Remove Godunov from LMeX sources. * Rewritte the advective flux divergence to comply with AMReX-Hydro way. * Update CI. * Feature balance (#9) * Add kin. energy derive function. * Add kin.energy derive and ParmParse temporals input. * Start setting-up run-time diagnostics. * Update MLNorm0 to not account for fine-covered cells. * Setup mass balance in runtime diagnostics. * Add temporal keys to FlameSheet regtests * Git ignore * Add gnuplot script for mass balance. * Fix runtime selection of reactor. (#10) * Missing AMReX-Hydro home in convergence testing. * Update Make.PeleLMeX * Update reactor in Sources. * Remove one call too many to deallocate of transport. * Update FlameSheet GMake * Add CVODE input keys. * Udpate GMake in Periodic and HotBubble * Fix typo on ReactorNull default: * Make LMeX GPU-compatible (#11) * Remove device from lineaChmeForcing. * Can't init capture in host_device functions. * Fix call to host function on device lambdas. * Change OMP. * Should be the same, but make sure. * Don't init transport for incompressible flows. * Missing Gpu Managed. Will be updated later. * Minor clean up in PeriodicCases. * Fix parm in FLameSheet too. * Restore FlameSheet 3D. * Remove unused. * Add Sundials memory helper. * Remove auto-TPL. Recompile all the source each time. Need fix. * Restore make TPL in GH workflow for now. * Fix velocity ghost cells for Nodal projection. Function (#12) should only overwrite Inflow BCs. * Implement closed chamber algorithm. (#13) * Add auto-detection of closed chamber and unable overwrite. Add PPquery of linear solves tolerances. * Add GammmaInv kernel. * Move MFSum in Utils and initialize uncovered volume computation. * MAC projection function handles closed chamber corrections. * Nodal projection functions handle -/+ of Sbar in RHS. * Remove TODO comment. * Pass dp0dt in diffusion forcing. * Pass dp0dt in Advection forcing. * Add pOld <-> pNew in advance function. * Add adjustPandDivU in Eos file. * Add accessor to divU levels vector * Add declarations. * Add ambient pressure to checkpoint file header. * Uses pNew to get dPdt. * Fix BL_PROF in UMAC * Add an enclosed flame test to test closed chamber. * Add a CI testing closed chamber.
baperry2
pushed a commit
to baperry2/PelePhysics
that referenced
this pull request
Dec 19, 2024
update sundials - sycl 2025 fix (AMReX-Combustion#551)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git merge day +1