GCM for liquid fuel properties in spray#615
Merged
baperry2 merged 25 commits intoAMReX-Combustion:developmentfrom Sep 8, 2025
Merged
GCM for liquid fuel properties in spray#615baperry2 merged 25 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 25 commits intoAMReX-Combustion:developmentfrom
Conversation
d-montgomery
commented
Sep 1, 2025
d-montgomery
commented
Sep 1, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Group Contribution Method (GCM) for estimating liquid-phase properties in the spray module, building on previous reorganization work and providing an alternative to the original PeleMP approach. The GCM uses correlations based on molecular structure information to predict thermodynamic properties of multi-component jet fuels.
Key changes:
- Adds GCM implementation with temperature-dependent correlations for liquid properties
- Restructures liquid property classes with inheritance hierarchy
- Consolidates unit conversion utilities and spray units definition
- Updates documentation to cover both PeleMP and GCM approaches
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| UnitConversions.H | Adds temperature conversion functions (Celsius to Kelvin) |
| SpraySetup.cpp | Reorganizes liquid property initialization and adds molecular weight handling |
| SprayProperties.H | Major refactor adding GCM implementation, base class hierarchy, and consolidated unit definitions |
| SprayFuelData.H | Removes duplicate unit definitions (moved to SprayProperties.H) |
| Drag.H | Updates to use liquid molecular weights and simplified vapor state calculations |
| WallFilm.H | Simplifies molecular weight calculation using new mixture functions |
| Spray.rst | Comprehensive documentation update covering both property estimation methods |
| CONTRIBUTING.md | Minor formatting improvements with code block syntax |
Comments suppressed due to low confidence (1)
Source/Spray/SprayProperties.H:1
- The input parameter name 'SP_accentric_factor' in the documentation (line 426) has a spelling error. It should be 'acentric' not 'accentric'.
#ifndef SPRAYPROPERTIES_H
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
baperry2
reviewed
Sep 3, 2025
baperry2
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the reorganization work done in #581, #602, and #613, and introduces a new group-contribution method (GCM) for estimating liquid-phase properties in the spray module. This method has been shown to be effective at estimating thermodynamic properties of multi-component jet fuels with limited information about the specific compounds in the fuel. Using the GCM in Pele requires:
SPRAY_GCM=TRUEin theGNUmakefileof the associated PeleLMeX case directoryTo minimize headaches from unit conversions, the GCM method is currently only compatible with PeleLMeX, but it can be adapted for cgs units in the future. I've tested the implementation in
PeleLMeX/Exec/RegTests/SingleDropEvapand plan to conduct additional tests with POSF10264 in the future. Here is a corresponding LMeX PR where all test cases can be run PeleLMeX #561Below are the initial results. I think where this method will shine is dealing with complex multi-component fuels like POSF10264, where current mechanisms only have one liquid-phase species and are unable to capture preferential evaporation.
