enable dumping the 1st plane of ghost cells with DiagFramePlane#572
enable dumping the 1st plane of ghost cells with DiagFramePlane#572baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
Conversation
malihass
left a comment
malihass
left a comment
There was a problem hiding this comment.
Thanks for that, it works great in a turbulent channel flow case!
One change that would be good
Can we dump the error message or the info message only once (not MPI process times)?
Also (not for this PR), but it the LMeX doc, it would be nice to have the dump_ghost_if_OOB option.
|
Modified so the warning only gets printed once. Leaving the error as is, because we want to ensure an error is always raised if needed. Moved Docs here so we don't have to maintain separate Docs for this capability in LMeX and C, and added something for the new flag. |
malihass
left a comment
malihass
left a comment
There was a problem hiding this comment.
Super! Thanks for the change
Yesterday we noticed that the plane at Step 0 was not dumped, so if you want to add this that would be great, otherwise it is already great the way it is!
|
The change to dump the plane at step 0 will need to go in PeleC/LMeX I think |
2 participants
Currently if the requested plane location for the DiagFramePlane Diagnostic is not available, we just silently do nothing. After this PR, we will raise an error, unless the user has specified the
dump_ghost_if_OOBoption, in which case the first ghost cell in the relevant face will be dumped (all levels get their respective first ghost cell). This is intended as debugging capability, for example giving users direct access to visualize what bcnormal is doing.In PeleLMeX, the first ghost cell on domain boundaries corresponds to the BC at the boundary face.
In PeleC, the first ghost cell on domain boundaries corresponds to the state 1/2 cell over from boundary face, which gets set such that applying standard operators will lead to the desired values on the face.