peleparams: common data container for PMF, transport (others in future)#507
Merged
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom Jun 7, 2024
Merged
Conversation
marchdf
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes a piece from #492 to make reviewing easier.
PeleParams is a class template that allows copying arbitrary data structures from host to device, taking advantage of The_Pinned_Arena (simple data structures of fixed size can be copied directly without dealing with that though). An InitParm class must be defined with a function that populates the data structure (and cleans it up, if needed). There's some funky stuff to be able to use PeleParams to create derived versions of a base data structure, but for most use cases that can be transparently ignored. Written as a generalization of the old PMFData structure.
Will require minor downstream changes in LMeX/C.
Also implements bugfix in PMF interpolation from AMReX-Combustion/PeleC#808