n_files input for DiagFramePlane diagnostic#485
Merged
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom Mar 28, 2024
Merged
n_files input for DiagFramePlane diagnostic#485baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
Conversation
marchdf
approved these changes
Mar 26, 2024
SreejithNREL
pushed a commit
that referenced
this pull request
May 27, 2024
Co-authored-by: Thomas Howarth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an input to specify a number of files to write when making planes using the DiagFramePlane diagnostic. The current hardcoded min(256,NProcs) was writing many very small files. Perhaps the default could also be reduced.