Move PeleMP Source files to PelePhysics#448
Merged
marchdf merged 504 commits intodevelopmentfrom Dec 6, 2023
Merged
Conversation
added 30 commits
December 4, 2023 17:16
… wall and a cell center, add more checks in case a virtual particle has moved behind an EB
… gas phase species than its based on, move general setup functionality into SprayParticleContainer
…ray inputs and equations to documentation
…checking at domain boundaries
…e statements in soot files
…ay inputs to documentation
…o sprayInjection function, added SprayJet.cpp and made some functions virtual, added second initializer for Distribution classes
…at can be set by the user
Contributor
|
Looks good, but I think we should wait to merge until opening parallel PRs in C and LMeX that account for the change and pass the relevant tests |
jrood-nrel
approved these changes
Dec 5, 2023
Contributor
|
I don't mind merging any time. The other projects point to their respective commits of PelePhysics that work until we change them. |
Contributor
Author
|
@baperry2 what Jon said was what I was thinking. I guess I was thinking we get PelePhysics to where we want it to be (for the MP stuff at least) and then update the submodules in the other codes and make the appropriate changes. Not set on this obv if you have other thoughts. |
baperry2
approved these changes
Dec 6, 2023
Contributor
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
My thought was that it could get unwieldy to make all the corresponding changes in C and LMeX at once rather than incrementally. But up to you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.