Merged
Conversation
…routine to save a injection data to prevent restarts from interferring with injection, will add function to read data next, ran clang-format
…comodate max jet velocity, fixed some clang-tidy issues
List with found names as not being updated
Contributor
|
I'm confused by this so far, but it's still a draft. |
Contributor
Author
|
This starts the migration of files from PeleMP to PelePhysics. I started with files that matter less. |
Contributor
|
I like that authorship is preserved and things can be done incrementally, so I think this is a good approach for bringing stuff in from PeleMP. I do think we should consider how best to organize things as we move stuff from PeleMP though. Right now we have a mix of both C++ source code and python utilities in both the Support and Utility, which I think is a bit confusing. |
jrood-nrel
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do we think? I think this preserves (some) history (at least authorship) and I can do things piece by piece.