Anne/feature default cpp optional f90#112
Merged
drummerdoc merged 5 commits intodevelopmentfrom Aug 13, 2020
Merged
Conversation
added 4 commits
August 12, 2020 16:49
need to specify to compile F90 routines. The default is: no F90 anymore, only CPP
Only compile the fuego_chemistry module when F90 capability is required
…o, fix the USE_KLU vs USE_KLU_PP flag. Only use USE_KLU_PP Minor changes: revert to USE_CUDA=FALSE in test cases
drummerdoc
approved these changes
Aug 13, 2020
Contributor
drummerdoc
left a comment
drummerdoc
left a comment
There was a problem hiding this comment.
the only question is whether it makes sense to have separate F90 flags for all three things...could be USE_F90_PP
Contributor
Author
|
ok sure I can do that too |
drummerdoc
approved these changes
Aug 13, 2020
EnnaDelfen
pushed a commit
that referenced
this pull request
Aug 13, 2020
drummerdoc
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add species mass balance dmYdt = Sum( Flux(A) + Flux(D) + R). * Update doc. * Add species balance to FlameSheet regtest.
baperry2
added a commit
that referenced
this pull request
Dec 1, 2023
* Explicit filtering of hydro fluxes and source term. (#112) This commit implements explicit filtering of the hydro fluxes and source term (for both MOL and PPM code paths). This is necessary to perform explicitly filtered Large Eddy Simulations. Contains: - regressions tests - documentation - CMake implementation * Remove legacy Fortran code. (#252) * Use default for trivial constructors and only build HIP in CI for gfx908 (#434) * Use default for trivial constructors. * Only build HIP in CI for gfx908. * Update PelePhysics. * Fixes to header files (#439) * Fixes to header files. * Update PelePhysics submodule. * More fixes. * Initialize xdiff in HIT. * Invert some mfiter loops (#446) Co-authored-by: Jon Rood <[email protected]> * Add GPU syncs because MF ParallelFor is non-blocking (#471) * Rename header guards (#506) * Replace _OPENMP with AMREX_USE_OMP to support Ascent. (#519) * Address some warnings (#554) * remove dependence of Filter on Utilities (#710) * move files * docs for filter * use amrex Pi instead of PeleC Pi --------- Co-authored-by: Marc T. Henry de Frahan <[email protected]> Co-authored-by: Jon Rood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only compile CPP files if F90 not required. Makes it so that we can safely remove F90 files in the future !
NOTE: that means that by default DVODE is deprecated