run fcompare in CI#635
Conversation
|
Confirmed that this PR does catch intentional bugs (which have now been reverted): https://github.com/AMReX-Combustion/PeleLMeX/actions/runs/22740480520/job/65952674740 unitTest should still be failing because I added additional output variables that will not be in the output of the reference version (but all existing variables should now match with the intentional bugs reverted). |
There was a problem hiding this comment.
Pull request overview
Build a reference version of PeleLMeX in CI and compare regression-test outputs against a saved “gold” reference, aligning behavior with existing UnitTest comparisons.
Changes:
- Add CI support to optionally save golds, build a reference revision, and run comparison testing.
- Tighten UnitTest plotfile comparison to fail when expected fields are missing.
- Adjust projection update logic and extend UnitTest evaluate variables to support comparisons.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Source/PeleLMeX_Projection.cpp | Changes which state/gp MultiFabs are used during the velocity projection update. |
| Exec/UnitTests/DodecaneLu/inputs.3d | Adds additional derived/evaluated variables to the UnitTest output used for comparisons. |
| Docs/sphinx/manual/Troubleshooting.rst | Fixes a spelling issue in troubleshooting documentation. |
| .github/workflows/unitTest.yml | Makes fcompare fail if not all requested fields are found in plotfiles. |
| .github/workflows/ci.yml | Adds optional “reference build + compare” flow and configuration to save golds. |
Comments suppressed due to low confidence (1)
Source/PeleLMeX_Projection.cpp:1
- These kernels iterate over
ldataNew_p->statebut write velocity usingstate_old_ma[box_no], which updates the old state arrays instead of the new state (and also risks mismatched FAB indexing if layouts ever diverge). Use the arrays fromldataNew_p->stateforvelwhen applying the projection update, and ensure thegp_*array you apply corresponds to the same time/state you intend to update.
#include <PeleLMeX.H>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Build a reference version of PeleLMeX and compare results for RegTests during CI. Mirrors AMReX-Combustion/PeleC#917 and what is done for the UnitTests.