Velocity Projection Bug Fix#634
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug introduced in #556 where the old and new state/gradient pressure (gp) arrays were swapped in the velocity projection step. The fix ensures velocity updates are applied to the new state using the old gradient pressure.
Changes:
- Swapped
state_old_ma/gp_new_matostate_new_ma/gp_old_main the variable-density branch - Swapped the same arrays in the constant-density branch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EnnaDelfen
left a comment
There was a problem hiding this comment.
This seems to have solved the issue on my end and the log file for my runs are now similar to what I had in my previous November version (incl. flamesheet TC). Can't really comment on the appropriateness of the format of the coding but it seems fairly straightforward. Thanks for attending to this so quickly.
ThomasHowarth
left a comment
There was a problem hiding this comment.
Thanks for catching this Bruce - not sure how this got lost in translation in the previous PR; apologies.
|
I'll release another minor version soon because this is a substantial change. |
Proposed fix for #633. Looks like old and new states got swapped during #556.