Skip to content

deltaT iters: recompute RhoH before starting#627

Merged
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
baperry2:deltaT-iter-fix
Feb 23, 2026
Merged

deltaT iters: recompute RhoH before starting#627
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
baperry2:deltaT-iter-fix

Conversation

@baperry2
Copy link
Copy Markdown
Collaborator

@baperry2 baperry2 commented Feb 21, 2026

In the diffusion update, we first implicitly update species diffusion, then update temperature diffusion using a linearly implicit iterative approach where the update is done in terms of temperature rather than enthalpy, and iterated until the enthalpy of the updated system converges. In the past, we've observed that the residual in this iterative solve increases on the first step before decreasing and converging (usually).

The reason for this odd behavior is that the mixture enthalpy of the new state is not updated after species are diffused and updated to the new state. Because of the chemical enthalpy of species, this diffusion affects the mixture enthalpy. If we neglect it, we start out with an inconsistent enthalpy state for the deltaT iteration process, which gets corrected when enthalpy is recomputed after the first iteration (leading to the jump is residual on the second iteration). By updating the mixture enthalpy before the iteration process starts, we start out with a consistent value, and the iterations converge monotonically. Enthalpy is updated after each iteration anyway and this does not affect the value that the enthalpy converges to.

As a result of these modifications, deltaT iterations converge typically in one less iteration, avoiding one MLMG solve, which has a mild performance benefit.

It is not yet known whether this adjustment will solve the occasional issue where convergence stalls with the LiDryer mechanism, but I expect that is a separate issue and will not be affected.

Demonstration of improved convergence for the FlameSheet case with DRM19 run for 200 timesteps with 2 SDC iterations:
FlameSheet-DRM19-SDCiter 1
FlameSheet-DRM19-SDCiter 2

Demonstration for a jet in crossflow H2 flame with LiDryer run for 200 timesteps with 1 SDC iteration:
JICFflame-LiDryer-SDCiter 1

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the convergence behavior of the deltaT iterative solver in the diffusion update by recomputing mixture enthalpy (RhoH) after species diffusion and before starting temperature diffusion iterations. This ensures the enthalpy state is consistent with the updated species composition, eliminating an initial residual jump and reducing iterations by approximately one per solve.

Changes:

  • Added RhoH recomputation step between species diffusion update and deltaT iterations
  • Implementation uses parallel GPU kernel to update enthalpy based on current density, species, and temperature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@esclapez
Copy link
Copy Markdown
Collaborator

Nice ! Good catch Bruce.

Copy link
Copy Markdown
Contributor

@d-montgomery d-montgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll echo @esclapez, good catch, @baperry2!

@baperry2 baperry2 merged commit cb42cb9 into AMReX-Combustion:development Feb 23, 2026
38 checks passed
@baperry2 baperry2 deleted the deltaT-iter-fix branch February 23, 2026 17:23
@drummerdoc
Copy link
Copy Markdown

Ahh, that's excellent! Still might need to add another step to incorporate the time-explicit parts of the update in the enthalpy equation, but this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants