deltaT iters: recompute RhoH before starting#627
Merged
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom Feb 23, 2026
Merged
deltaT iters: recompute RhoH before starting#627baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the convergence behavior of the deltaT iterative solver in the diffusion update by recomputing mixture enthalpy (RhoH) after species diffusion and before starting temperature diffusion iterations. This ensures the enthalpy state is consistent with the updated species composition, eliminating an initial residual jump and reducing iterations by approximately one per solve.
Changes:
- Added RhoH recomputation step between species diffusion update and deltaT iterations
- Implementation uses parallel GPU kernel to update enthalpy based on current density, species, and temperature
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Nice ! Good catch Bruce. |
|
Ahh, that's excellent! Still might need to add another step to incorporate the time-explicit parts of the update in the enthalpy equation, but this is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the diffusion update, we first implicitly update species diffusion, then update temperature diffusion using a linearly implicit iterative approach where the update is done in terms of temperature rather than enthalpy, and iterated until the enthalpy of the updated system converges. In the past, we've observed that the residual in this iterative solve increases on the first step before decreasing and converging (usually).
The reason for this odd behavior is that the mixture enthalpy of the new state is not updated after species are diffused and updated to the new state. Because of the chemical enthalpy of species, this diffusion affects the mixture enthalpy. If we neglect it, we start out with an inconsistent enthalpy state for the deltaT iteration process, which gets corrected when enthalpy is recomputed after the first iteration (leading to the jump is residual on the second iteration). By updating the mixture enthalpy before the iteration process starts, we start out with a consistent value, and the iterations converge monotonically. Enthalpy is updated after each iteration anyway and this does not affect the value that the enthalpy converges to.
As a result of these modifications, deltaT iterations converge typically in one less iteration, avoiding one MLMG solve, which has a mild performance benefit.
It is not yet known whether this adjustment will solve the occasional issue where convergence stalls with the LiDryer mechanism, but I expect that is a separate issue and will not be affected.
Demonstration of improved convergence for the FlameSheet case with DRM19 run for 200 timesteps with 2 SDC iterations:


Demonstration for a jet in crossflow H2 flame with LiDryer run for 200 timesteps with 1 SDC iteration:
