Add a derived variable for element fractions#624
Merged
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom Feb 17, 2026
Merged
Add a derived variable for element fractions#624baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new derived field for element mass fractions (“element_fractions”) intended for Fuego and SRK EOS configurations, and wires it into plotting/regression inputs.
Changes:
- Register a new derived quantity
element_fractions(conditional on EOS identifier being Fuego/SRK). - Implement
pelelmex_derelementfracand expose it in the derive function header. - Add
element_fractionsto the FlameSheet regression testamr.derive_plot_vars.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Source/PeleLMeX_Setup.cpp | Registers the new derived variable and assigns per-component names. |
| Source/PeleLMeX_DeriveFunc.cpp | Implements the GPU kernel that computes element fractions via EOS conversion. |
| Source/PeleLMeX_DeriveFunc.H | Declares the new derive function. |
| Exec/RegTests/FlameSheet/flamesheet-drm19-2d.inp | Requests element_fractions in plot-derived outputs for the regtest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d-montgomery
approved these changes
Feb 17, 2026
Contributor
d-montgomery
left a comment
d-montgomery
left a comment
There was a problem hiding this comment.
Thanks for adding this!
baperry2
merged commit ab5601f
into
AMReX-Combustion:development
18 of 56 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only supported for Fuego and SRK EOS.
Will need AMReX-Combustion/PelePhysics#653