Fix how the species fluxes are summed#607
Merged
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom Dec 19, 2025
Merged
Fix how the species fluxes are summed#607baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
Conversation
baperry2
approved these changes
Dec 16, 2025
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Looks good to me but @SreejithNREL please confirm that this is consistent with what you intended for the bpatches before we merge.
SreejithNREL
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes how the species fluxes are summed for each group in speciesBalancePatch().
The old code was using
j = 0, 1, 2...directly to index speciesFlux, but it needed to:speciesinGroup[i]kkto get the correct flux fromspeciesFlux[k]This fix ensures that fluxes are correctly summed for all group definitions, including multiple groups like {Air:O2,N2} {Fuel:POSF10264}