Update device copy of FCData#602
Merged
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom Dec 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where the flow controller was not being applied on GPU runs. The issue occurred because the device copy of FCData within ProbParm was not synchronized after initActiveControl() updated the host copy. Specifically, ctrl_active remained at its default value of 0 on the device, causing the flow controller to be bypassed in GPU kernels such as bcnormal() in the TripleFlame test case.
Key Changes:
- Added device memory synchronization in
initActiveControl()after updating host FCData values - Follows the existing pattern used in
activeControl()for device copy updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baperry2
approved these changes
Dec 10, 2025
terencelehmann
pushed a commit
to ITV-RWTH/PeleLMeX
that referenced
this pull request
Jan 13, 2026
* Point PelePhysics to development branch for GCM * Add compilation flag for SPRAY_GCM * Update PelePhysics * Update PelePhysics * Update PelePhysics * Revert PelePhysics to 22d8cd3 * Formatting from PelePhysics * Rename var from PelePhysics * Rebase PelePhysics to delete merge with development * Remove extra rho_part from Drag.H for LMeX formatting * merge PelePhysics AMReX-Combustion#603 into gcm-dev * Update PelePhysics to 8f9a39f * Update PelePhysics to AMReX-Combustion#602 * First working GCM in Pele * Test GCM vs. PeleMP * Update PP * Change compile flag for GCM * Point PP to AMReX-Combustion/PelePhysics * Point to PP dev * Point to latest PP dev * Add GCM test for mixture JP8, make Validate.py more user friendly * Python formatting * Revert .gitmodules * Add GCM case to CI test, requires SPRAY_GCM in CMake, cleanup RegTest/SingleDropEvap * Update input file in Tests/CMakeLists.txt * Update CMake for CI test * Add input file for CI test * Revert Tests/CMakeLists.txt * Update PelePhysics * Change to PELE_PHYSICS_SPRAY_GCM, point to latest PelePhysics dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device copy of FCData was not updated in initActiveControl(), therefore (prob_parm.FCData.ctrl_active == 0U) is true when running on GPU in Exec/RegTests/TripleFlame/pelelmex_prob.H within bcnormal for example and the controller is not applied to the inlet