Update LMeX for use with many-to-one spray capability#593
Merged
baperry2 merged 37 commits intoAMReX-Combustion:developmentfrom Feb 18, 2026
Merged
Update LMeX for use with many-to-one spray capability#593baperry2 merged 37 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 37 commits intoAMReX-Combustion:developmentfrom
Conversation
Merged
9 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables many-to-one spray capability in PeleLMeX, allowing multiple liquid species to deposit into a single or fewer gas-phase species. The implementation includes updates to spray source computation, test case configurations for JP8 fuel validation with 67 liquid species depositing to HyChem POSF10268 gas-phase species, and comprehensive validation through the SingleDropEvap test cases with both PeleMP and GCM models.
Changes:
- Updated spray source indexing to dynamically compute energy source index based on the number of pseudo-components
- Added new test cases and input files for JP8 fuel with many-to-one capability
- Enhanced Python validation and plotting scripts to support multiple fuel decomposition strategies
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Submodules/PelePhysics | Updated submodule to commit supporting many-to-one spray capability |
| Source/PeleLMeX_SprayParticles.cpp | Removed hard-coded spray fuel number constraints and updated source index computation |
| Exec/RegTests/SingleDropEvap/sprayPropsMP_mixture_jp8.inp | Added MP properties for single-component POSF10264 representation |
| Exec/RegTests/SingleDropEvap/sprayPropsMP_jp8.inp | Added MP properties for 67-component JP8 decomposition |
| Exec/RegTests/SingleDropEvap/sprayPropsMP_heptane-decane.inp | Added MP properties for heptane-decane mixture |
| Exec/RegTests/SingleDropEvap/sprayPropsGCM_mixture_jp8.inp | Updated GCM properties with new FuelLib commit |
| Exec/RegTests/SingleDropEvap/sprayPropsGCM_jp8.inp | Added GCM properties for 67-component JP8 decomposition |
| Exec/RegTests/SingleDropEvap/sprayPropsGCM_heptane-decane.inp | Updated initial mass fractions for consistency |
| Exec/RegTests/SingleDropEvap/single-drop-evap-mp.inp | Removed redundant input file (consolidated into single-drop-evap.inp) |
| Exec/RegTests/SingleDropEvap/single-drop-evap-mp-manifold.inp | Refactored to use external spray properties file |
| Exec/RegTests/SingleDropEvap/single-drop-evap-gcm.inp | Updated to reference correct spray properties file |
| Exec/RegTests/SingleDropEvap/pelelmex_prob.cpp | Added IO processor check to prevent parallel file write conflicts |
| Exec/RegTests/SingleDropEvap/Validate.py | Enhanced to support JP8 variants and additional runtime configuration |
| Exec/RegTests/SingleDropEvap/SprayParticlesInitInsert.cpp | Added debug output for liquid mass fractions |
| Exec/RegTests/SingleDropEvap/README.md | Updated documentation for consolidated input file structure |
| Exec/RegTests/SingleDropEvap/ExtractData.py | Added support for separate reference name lookup |
| Exec/RegTests/SingleDropEvap/CompareResults.py | Enhanced plotting for JP8 case variants with improved legend placement |
| Exec/RegTests/SingleDropEvap/CaseInfo.py | Refactored to support many-to-one deposition and JP8 case variants |
| .github/workflows/linux.yml | Added CI test for RungeJP8 GCM many-to-one case |
Comments suppressed due to low confidence (1)
Exec/RegTests/SingleDropEvap/Validate.py:1
- The generation date
2025-12-15is in the future. Ensure this date reflects when the file was actually generated or update it to the current date.
import os
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baperry2
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the changes necessary for the new many-to-one spray capability to work in PeleLMeX (see PelePhysics #633. A few comments:
To do: