Make sure viscturb is always initialized when plotting#592
Merged
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom Nov 18, 2025
Merged
Make sure viscturb is always initialized when plotting#592baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses uninitialized turbulent viscosity values in plot files during initialization. The fix ensures that turbulent viscosity is properly computed and available for plotting in both the initial state (plt00000) and the optional pre-iteration state (plot_init_state).
Key Changes:
- Switched plot file generation to use turbulent viscosity from the "new" state instead of "old" state
- Added turbulent viscosity computation during initialization before writing the initial plot file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/PeleLMeX_Plot.cpp | Changed turbulent viscosity source from m_leveldata_old to m_leveldata_new for all spatial dimensions |
| Source/PeleLMeX_Init.cpp | Added calcTurbViscosity call during initialization when LES is enabled, before optional initial plot file output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d-montgomery
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The turbulent viscosity is not currently computed on initialization in the "old" state, only the "new" state. So if we don't have any init iters, the state plotted for
plt00000is uninitialized. Also, the "-1" state that gets plotted with theplot_init_stateoption is never properly initialized.Two fixes: