Add stationary reference frame option for FlameSheet#590
Merged
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom Jan 22, 2026
Merged
Add stationary reference frame option for FlameSheet#590baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable reference frame option for the FlameSheet problem, allowing users to choose between a flame-attached reference frame (default) and a laboratory reference frame. The prob.ref_frame parameter can be set to either flame or lab.
- Added
PmfReferenceFrameenum withlabandflameoptions - Modified boundary condition velocity assignment to respect the reference frame choice
- Added parameter query to read
ref_framefrom input files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pelelmex_prob.H | Defines the PmfReferenceFrame enum, adds ref_frame member to MyProbParm struct with default value of flame, and implements conditional velocity assignment in bcnormal function based on the selected reference frame |
| pelelmex_prob.cpp | Adds parameter query to read ref_frame configuration from input files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baperry2
force-pushed
the
pmf-ref-frame
branch
from
ca0bb48 to
dcc755a
Compare
malihass
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prob.ref_framecan be set tolaborflameorconstant_velocity, the latter requiringprob.moving_frame_velocityto also be specified.