Skip to content

Remove incompressible assertion for pelelmex_derturbforcing #584

Merged
jrood-nrel merged 2 commits intodevelopmentfrom
fix-incomp-hit
Oct 29, 2025
Merged

Remove incompressible assertion for pelelmex_derturbforcing #584
jrood-nrel merged 2 commits intodevelopmentfrom
fix-incomp-hit

Conversation

@marchdf
Copy link
Copy Markdown
Contributor

@marchdf marchdf commented Oct 29, 2025

No description provided.

@baperry2
Copy link
Copy Markdown
Collaborator

What is the rationale here? The HIT tests are the only ones we have that run in incompressible mode, so it would be better to leave the test in that mode so it continues to be tested (also, it looks like the test is set up to require it anyway).

@marchdf
Copy link
Copy Markdown
Contributor Author

marchdf commented Oct 29, 2025

Basically the dashboard sees this : https://my.cdash.org/tests/313089995 and I am trying to fix...

@baperry2
Copy link
Copy Markdown
Collaborator

I think it's a mistake in that ASSERT in the derive function.

AMREX_ASSERT(!a_pelelm->m_incompressible);

I think it should assert that it is incompressible to derive the forcing, not that it isn't incompressible. At least that's what would be consistent with here:

AMREX_ALWAYS_ASSERT(is_incompressible != 0);

Probably not caught because it's an ASSERT in the derive function instead of ALWAYS_ASSERT.

@baperry2
Copy link
Copy Markdown
Collaborator

Or maybe that ASSERT could just be removed altogether, looking at the contents of the function it seems to be able to support either incompressible or low Mach.

@marchdf
Copy link
Copy Markdown
Contributor Author

marchdf commented Oct 29, 2025

I like that even better

@marchdf marchdf changed the title Switch incompressible flag on hit forced Remove incompressible assertion for pelelmex_derturbforcing Oct 29, 2025
@marchdf
Copy link
Copy Markdown
Contributor Author

marchdf commented Oct 29, 2025

I removed that assertion and reverted the HIT input file.

@jrood-nrel jrood-nrel enabled auto-merge (squash) October 29, 2025 19:21
@jrood-nrel jrood-nrel merged commit 316b7eb into development Oct 29, 2025
24 checks passed
@jrood-nrel jrood-nrel deleted the fix-incomp-hit branch October 29, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants