Remove incompressible assertion for pelelmex_derturbforcing #584
Remove incompressible assertion for pelelmex_derturbforcing #584jrood-nrel merged 2 commits intodevelopmentfrom
pelelmex_derturbforcing #584Conversation
|
What is the rationale here? The HIT tests are the only ones we have that run in incompressible mode, so it would be better to leave the test in that mode so it continues to be tested (also, it looks like the test is set up to require it anyway). |
|
Basically the dashboard sees this : https://my.cdash.org/tests/313089995 and I am trying to fix... |
|
I think it's a mistake in that ASSERT in the derive function. PeleLMeX/Source/PeleLMeX_DeriveFunc.cpp Line 1568 in 1c6ef47 I think it should assert that it is incompressible to derive the forcing, not that it isn't incompressible. At least that's what would be consistent with here: PeleLMeX/Exec/RegTests/HIT/pelelmex_prob.H Line 109 in 1c6ef47 Probably not caught because it's an ASSERT in the derive function instead of ALWAYS_ASSERT. |
|
Or maybe that ASSERT could just be removed altogether, looking at the contents of the function it seems to be able to support either incompressible or low Mach. |
|
I like that even better |
pelelmex_derturbforcing
51252ec to
20d8b0b
Compare
|
I removed that assertion and reverted the HIT input file. |
No description provided.