fix device pointer capture in derive coord func#572
Merged
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom Sep 30, 2025
Merged
fix device pointer capture in derive coord func#572baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical device pointer issue in the coordinate derivation function that was causing segfaults in GPU simulations. The problem was that geomdata.ProbLo() was being called from the host and the resulting host pointer was then used on the device.
- Removes pre-computed dx/dy/dz variables that were captured from host
- Updates GPU kernels to use
geomdata.ProbLo(dim)andgeomdata.CellSize(dim)methods directly on device - Simplifies lambda capture by only passing
geomdatainstead of multiple separate variables
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geomdata.ProbLo()was being called from host, resulting in a host pointer that was then used on device, leading to segfaults for GPU simulations.Also, rather than capturing dx/dy/dz and geomdata to device separately, just use geomdata to determine dx/dy/dz in the dercoord kernels.
Necessary to run FlameSheet case on Aurora.