Allow LES to use mixture averaged transport for molecular diffusion#558
Merged
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom Sep 8, 2025
Merged
Conversation
d-montgomery
reviewed
Sep 3, 2025
Source/PeleLMeX_Setup.cpp
Outdated
| if (m_fixed_Le != 0 && !m_do_les) { // Only ask for Lewis number when not | ||
| // LES, determined by Prandtl and | ||
| // Schmidt outside of this | ||
| m_Lewis_inv = m_Prandtl_inv / m_Schmidt_inv; |
Contributor
There was a problem hiding this comment.
Should this be m_Lewis_inv = m_Schmidt_inv / m_Prandtl_inv so that
Collaborator
Author
There was a problem hiding this comment.
Good catch, I think you're right. This was carried over from before, but the line is also inconsistent with how m_Schmidt_inv is defined on line 513 below, so I've changed it.
d-montgomery
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when LES is activated, fixed_Le and fixed_Pr are also automatically activated, so we use Prandtl, Schmidt, and Lewis numbers for both turbulent and molecular transport. Instead, we should allow fixed_Le and fixed_Pr to be off when using LES. For example, in H2 combustion, we may want nonunity Le molecular diffusion while still applying an LES model.