Remove using namespace amrex (1)#550
Merged
jrood-nrel merged 12 commits intoAMReX-Combustion:developmentfrom Aug 13, 2025
Merged
Remove using namespace amrex (1)#550jrood-nrel merged 12 commits intoAMReX-Combustion:developmentfrom
jrood-nrel merged 12 commits intoAMReX-Combustion:developmentfrom
Conversation
Collaborator
|
The convention that is nominally followed is I'm open to either way. Using the namespace where possible does make the code less verbose and more readable. But if we do it in cpp but not H, it makes it annoying when moving code back and forth between them. |
Contributor
Author
|
I definitely think we should remove |
baperry2
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not liking all the inconsistency so trying to fix all of it.